Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(vm): Run multivm tests with shadowing #3137

Merged
merged 6 commits into from
Oct 23, 2024
Merged

test(vm): Run multivm tests with shadowing #3137

merged 6 commits into from
Oct 23, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 21, 2024

What ❔

Runs shared unit tests in the multivm crate for the shadowed VM.

Why ❔

Allows to cheaply check VM divergences.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@slowli slowli marked this pull request as ready for review October 21, 2024 11:26
perekopskiy
perekopskiy previously approved these changes Oct 23, 2024
View reviewed changes
core/lib/multivm/src/versions/testonly/get_used_contracts.rs Outdated Show resolved Hide resolved
@slowli slowli added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 84986f4 Oct 23, 2024
33 checks passed
@slowli slowli deleted the aov-pla-1053-run-multivm-tests-on-shadow-vm branch October 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonazan joonazan joonazan approved these changes

@perekopskiy perekopskiy perekopskiy left review comments

@Deniallugo Deniallugo Awaiting requested review from Deniallugo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @joonazan @perekopskiy